Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes wrong dropship attachment planes #5495

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

Vicacrov
Copy link
Contributor

@Vicacrov Vicacrov commented Jan 19, 2024

About the pull request

Fixes #5494 that I broke with #5475

sorry

Explain why it's good for the game

You can attach engines/weapons to the dropships again and not have xeno structures layer below the floor attach points.

Testing Photographs and Procedure

  1. Attach various equipment to the dropships
  2. See if they show up
  3. Spawn xeno structures on the floor attach points

see screenshots below

Screenshots & Videos

image

image

image

image

Changelog

🆑
fix: Fixes engine/weapon attach points layering below the dropship walls.
/:cl:

@github-actions github-actions bot added Mapping did you remember to save in tgm format? Fix Fix one bug, make ten more labels Jan 19, 2024
@cuberound
Copy link
Contributor

@Vicacrov
Copy link
Contributor Author

south doors are broken and there are missing tiles under ds, might be pssibly related to this https://cdn.discordapp.com/attachments/745447048261795890/1197987175183163393/image.png?ex=65bd4380&is=65aace80&hm=abcb9780bef8c57822d74b0f80a3f0966121c1efa27b6a9b05a8efb16352803f&

It is more likely #5165, my PR does not touch either of those turfs and I cannot see it on my local branch:

image

@harryob harryob added this pull request to the merge queue Jan 20, 2024
Merged via the queue into cmss13-devs:master with commit 6631233 Jan 20, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Jan 20, 2024
@Vicacrov Vicacrov deleted the attach_points_fix_fix branch March 6, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more Mapping did you remember to save in tgm format?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropship engine system attach point(s) are unreachable.
3 participants